Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/skipto5.7.2 Instant scrolling, number of headings and landmarks and about option #3210

Closed
wants to merge 135 commits into from
Closed

Update/skipto5.7.2 Instant scrolling, number of headings and landmarks and about option #3210

wants to merge 135 commits into from

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Jan 7, 2025 •
edited
Loading

Updates include:

  • Scollto landmark or heading feature when navigating menu items
  • Added number of headings and landmarks to group labels
  • Scrolling list for landmarks and headings when there are a large number of either one, so the group labels are always vsible
  • Added an about option in the menu for people to learn abut SkipTo.js
  • Support light-dark color scheme
  • Support forced-colors media query

WAI Preview Link (Last built on Tue, 07 Jan 2025 18:05:34 GMT).

mcking65 and others added 30 commits April 14, 2024 22:09
@mcking65
Create starter page for high contrast practice.
f13138e
@jongund
updated high-conrast
2aa2cff
@jongund
update high contrast
1e1a46e
@jongund
updated hc practice
6be229a
@jongund
added screen shots
6a48dca
@jongund
updated high contrast
262cb8c
@jongund
updated images
5615d1a
@jongund
updated high contrast
f22bd34
@jongund
creasted a temporary test page for system colors
192ba9b
@jongund
udpated test page
585de4d
@jongund
update high contrast
17f1481
@jongund
fixed linting error
e276315
@jongund
fixing linting errors
9888761
@jongund
fixing linting errors
f1babd7
@jongund
fixing linting errors
1a46146
@jongund
fixing linting errors
6ef309d
@jongund
fixing linting errors
65db7a8
@jongund
added some images
bdc3703
@jongund
added images
11f080a
@jongund
updated image references
089f114
@jongund
initial drati of high contrast practice
dc9045f
@jongund
added system colors table
5b217ce
@jongund
updated color calc to support rgba values
c18a8eb
@jongund
updated sample cell to use backgorund color
11fa5aa
@jongund
udpated sample styling
43c3089
@jongund
removed unused directory
cc4e6f0
@jongund
added color description to system color table
3772e35
@jongund
fixed linting errors
58c8461
@jongund
fixed linting errors
282e45d
@jongund
fixed linting errors
de2a7ac
jongund and others added 25 commits December 3, 2024 14:41
@jongund
fixed liniting errors
4537434
@howard-e
Run npm run fix to address remaining lint errors
5720724
@jongund @adampage
Update content/practices/high-contrast/high-contrast-practice.html
1d5c947 
Co-authored-by: Adam Page <[email protected]>
@jongund @adampage
Update content/practices/high-contrast/high-contrast-practice.html
53dbe60 
Co-authored-by: Adam Page <[email protected]>
@jongund @adampage
Update content/practices/high-contrast/high-contrast-practice.html
7da0456 
Co-authored-by: Adam Page <[email protected]>
@jongund @adampage
Update content/practices/high-contrast/high-contrast-practice.html
cf65fbc 
Co-authored-by: Adam Page <[email protected]>
@jongund @adampage
Update content/practices/high-contrast/high-contrast-practice.html
fe01022 
Co-authored-by: Adam Page <[email protected]>
@jongund @adampage
Update content/practices/high-contrast/high-contrast-practice.html
2b4dd4a 
Co-authored-by: Adam Page <[email protected]>
@jongund
updated section on bit-mapped image to include the possibility of fil…
affb5bd 
…ters or image substitution
@jongund
updated switch examples
aef3bc3
@jongund
fixed liniting bug
13e55f2
@jongund
fixed liniting bug
e759904
@jongund
updated switch example labels
4420165
@jongund
emphiszed actual colors in system color section
d9370d6
@jongund
updated summary table for bit-mapped vs SVG images
329dad2
@mcking65
editorial changes in increase contrast section
13be613
@mcking65
editorial changes to increase contrast testing section
5c138d0
@mcking65
improve description of increase contrast
bfec9e2
@mcking65
editorial revisions to dark mode testing
0f36b9b
@mcking65
editorial revisions to dark mode example section
32f05de
@mcking65
More editorial revisions to dark mode example section
43b2309
@jongund
updated switch example to use light-dark function
be84f63
@jongund
updated switch example to use light-dark function
284aff4
@jongund
editorial changes to color scheme description
49ff329
@jongund
updated skipto.js to version 5.7.2
d13645f
@jongund jongund changed the title Update/skipto5.7.2 Update/skipto5.7.2 Instant scrolling, number of headings and landmarks and about option Jan 7, 2025
@w3cgruntbot w3cgruntbot mentioned this pull request Jan 7, 2025
Closed
@mcking65
Copy link
Contributor

@jongund

Please close this and resubmit with a clean branch off the tip of main. I think you branched off of the high contrast practice branch.

@jongund jongund closed this Jan 14, 2025
@jongund jongund deleted the update/skipto5.7.2 branch January 14, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jongund @mcking65 @ariellalgilmore @howard-e